Switching to QED-it orchard Rust crate #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added .circleci/config.yml
* Added .circleci/config.yml
skyl
reviewed
May 13, 2022
| @@ -91,3 +91,4 @@ zcash_history = { git = "https://github.com/zcash/librustzcash.git", rev = "d5c5 | |||
| zcash_note_encryption = { git = "https://github.com/zcash/librustzcash.git", rev = "d5c5f048947d211c2fbef23ce986b329b91d1aa5" } | |||
| zcash_primitives = { git = "https://github.com/zcash/librustzcash.git", rev = "d5c5f048947d211c2fbef23ce986b329b91d1aa5" } | |||
| zcash_proofs = { git = "https://github.com/zcash/librustzcash.git", rev = "d5c5f048947d211c2fbef23ce986b329b91d1aa5" } | |||
| orchard = { git = "https://github.com/QED-it/orchard.git", rev = "6d2834bfd3230dc6a52b5b0c99e149f92455de69"} | |||
There was a problem hiding this comment.
this has changed already zcash@5fc38dd#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L86 🤔
There was a problem hiding this comment.
The referenced changes are because we focused on (and succeeded in) ensuring that zcashd 5.0.0 only depended on released crate versions. Adding this patch directive is the correct way for QEDIT to experiment with their patches to the orchard crate (and is precisely what we do for longer-lived development cycles).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to use the QED-it orchard crate.
Building locally would require using
CONFIGURE_FLAGS=--enable-online-rust ./zcutil/build.sh -j8, as that allows using the dependencies specified in Cargo.toml instead of those in Cargo.lockNote that when the orchard crate is updated, it will be required to update the Cargo.toml file to reflect any newer commits.